On Thu, Apr 19, 2018 at 08:57:30PM +0800, Qu Wenruo wrote: > > > On 2018年04月19日 20:49, David Sterba wrote: > > On Wed, Apr 11, 2018 at 05:08:12PM +0800, Qu Wenruo wrote: > >> This patch enhance the following things: > >> > >> - tree block header > >> * add generation and owner output for node and leaf > >> - node pointer generation output > >> - allow btrfs_print_tree() to not follow nodes > >> * just like btrfs-progs > >> > >> Please note that, although function btrfs_print_tree() is not called by > >> anyone right now, it's still a pretty useful function to debug kernel. > >> So that function is still kept for later use. > > > > It will stay of course, code deletionists have no chance removing useful > > debugging stuff. > > > > Reviewed-by: David Sterba <dste...@suse.com> > > > > Some time ago I improved the progs output of print-tree, this would be > > also good to port to kernel and we can then keep the files in 1:1. > > Definitely! > The current kernel print-tree is just better than no output, far from > human readable output. > I can't wait to port btrfs-progs print-tree to kernel, but that's over > 1000 lines for debug facility. > > If that's OK, I could start the port any time.
As print-tree is independent, you can do that incrementally, similar to the progs patches that factor out the per-key cases into functions. Anything you'd have we can merge rightaway, these are easy patches that can serve as a "relaxation" and relief from the difficult ones. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
