On 2018年05月07日 19:40, David Sterba wrote: > On Mon, May 07, 2018 at 10:20:57AM +0800, Qu Wenruo wrote: >>>>> +++ b/undelete-subvol.c >>>>> @@ -0,0 +1,53 @@ >>>>> +/* >>>>> + * Copyright (C) 2018 Fujitsu. All rights reserved. >>>> >>>> IIRC David will remove all such copy right line. >>>> Is there some principle about this, David? >>> >>> Are you referring to this patchset that replace GPL boilerplate by SPDX? >>> https://patchwork.kernel.org/patch/10321621/ >>> >>> However, I haven't seen a similar patch in btrfs-progs. >>> >> >> Nope, I mean David will remove the Copyright (C) line when applying. >> Although I'm not completely sure. > > Removing copyright notices should not be done without an ack from all > parties and I don't remove the copyright notices from patches if > present. > > I personally do not understand and see the point of the explicit > mentions if we have the signed-off by in git history. Also, when the > file is touched by many different people over time, the line 'copyright > by Evil Company' looks like all the credit goes to the single entitiy.
That seems to be the point. :) > > There's a point if the code is copied from another source, like the > test/sha* code that's from an RFC. > > So, I decided to not care too much about the copyright line as long as > there's a signed-off and authorship is GPL compatible. Glad that the policy is now clear. Thanks, Qu > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
signature.asc
Description: OpenPGP digital signature