On Thu, May 10, 2018 at 04:55:24PM +0300, Nikolay Borisov wrote: > > @@ -795,12 +752,25 @@ int btrfs_add_delayed_tree_ref(struct btrfs_fs_info > > *fs_info, > > struct btrfs_qgroup_extent_record *record = NULL; > > int qrecord_inserted; > > int is_system = (ref_root == BTRFS_CHUNK_TREE_OBJECTID); > > + int ret; > > + u8 ref_type = parent ? BTRFS_SHARED_BLOCK_REF_KEY : > > + BTRFS_TREE_BLOCK_REF_KEY; > > > > BUG_ON(extent_op && extent_op->is_data); > > ref = kmem_cache_alloc(btrfs_delayed_tree_ref_cachep, GFP_NOFS); > > if (!ref) > > return -ENOMEM; > > > > + if (parent) > > + ref_type = BTRFS_SHARED_BLOCK_REF_KEY; > > + else > > + ref_type = BTRFS_TREE_BLOCK_REF_KEY; > > Ooops, this if (parent) check is duplicated with the "parent ? " at the > beginning of the function. Would you care to delete either of them - > perhaps this one, or should I send a fixlet for you to squash ?
I removed it. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
