On 15.05.2018 20:52, Liu Bo wrote:
> @path->lock[i] is always true at this point.
You must explain why it's true. The reason is since at the beginning of
the for loop the check is performed :
if (!path->locks[i])
break;
Codewise it's ok:
Reviewed-by: Nikolay Borisov <nbori...@suse.com>
>
> Signed-off-by: Liu Bo <bo....@linux.alibaba.com>
> ---
> fs/btrfs/ctree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index f7c3f581f647..16d28a4ec54f 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -2330,7 +2330,7 @@ static noinline void unlock_up(struct btrfs_path *path,
> int level,
> no_skips = 1;
>
> t = path->nodes[i];
> - if (i >= lowest_unlock && i > skip_level && path->locks[i]) {
> + if (i >= lowest_unlock && i > skip_level) {
> btrfs_tree_unlock_rw(t, path->locks[i]);
> path->locks[i] = 0;
> if (write_lock_level &&
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
