On Wed, May 16, 2018 at 10:51:27AM +0800, Anand Jain wrote: > Balance args info is an important information to be reviewed for the > system audit. So this patch adds it to the kernel log. > > Example: > > -> btrfs bal start -dprofiles='raid1|single',convert=raid5 > -mprofiles='raid1|single',convert=raid5 /btrfs > > kernel: BTRFS info (device sdb): balance: start data profiles=raid1|single > convert=raid5 metadata profiles=raid1|single convert=raid5 system > profiles=raid1|single convert=raid5 > > -> btrfs bal start -dprofiles=raid5,convert=single > -mprofiles='raid1|single',convert=raid5 --background /btrfs > > kernel: BTRFS info (device sdb): balance: start data profiles=raid5 > convert=single metadata profiles=raid1|single convert=raid5 system > profiles=raid1|single convert=raid5 > > Signed-off-by: Anand Jain <anand.j...@oracle.com>
The log message can be useful, however please avoid using unchecked strcat and rewrite it without it if possible. You can find some inspiration how to join several strings in describe_relocation(). -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
