Re: [PATCH 03/15] btrfs-progs: Add functions to modify the used space by a root

[Qu Wenruo]

On 2018年06月08日 20:47, Nikolay Borisov wrote:
> Pull the necessary function, excluding locking. Required to enable
> integration of delayed refs.
> 
> Signed-off-by: Nikolay Borisov <nbori...@suse.com>
> ---
>  ctree.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/ctree.c b/ctree.c
> index 2c51580fec65..7b74716bf92f 100644
> --- a/ctree.c
> +++ b/ctree.c
> @@ -76,6 +76,18 @@ void add_root_to_dirty_list(struct btrfs_root *root)
>       }
>  }
>  
> +static void root_add_used(struct btrfs_root *root, u32 size)
> +{
> +        btrfs_set_root_used(&root->root_item,
> +                            btrfs_root_used(&root->root_item) + size);
> +}
> +
> +static void root_sub_used(struct btrfs_root *root, u32 size)
> +{
> +        btrfs_set_root_used(&root->root_item,
> +                            btrfs_root_used(&root->root_item) - size);
> +}
> +

So small that it can be included into the patch which uses this.

BTW, it would be better to do some basic underflow check here.
No need to return int, but some WARN_ON() would definitely help.

Thanks,
Qu

>  int btrfs_copy_root(struct btrfs_trans_handle *trans,
>                     struct btrfs_root *root,
>                     struct extent_buffer *buf,
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html