On Fri, Jun 15, 2018 at 05:19:07PM +0100, Filipe Manana wrote: > On Fri, Jun 15, 2018 at 4:54 PM, David Sterba <[email protected]> wrote: > > On Mon, Jun 11, 2018 at 07:24:28PM +0100, [email protected] wrote: > >> From: Filipe Manana <[email protected]> > >> Fixes: 12fcfd22fe5b ("Btrfs: tree logging unlink/rename fixes") > >> Reported-by: Vijay Chidambaram <[email protected]> > >> Signed-off-by: Filipe Manana <[email protected]> > > > > There are some warnings and possible lock up caused by this patch, the > > 1/2 alone is ok but 1/2 + 2/2 leads to the following warnings. I checked > > twice, the patch base was the pull request ie. without any other 4.18 > > stuff. > > Are you sure it's this patch? > On top of for-4.18 it didn't cause any problems here, plus the trace > below has nothing to do with renames, hard links or fsync at all - > everything seems stuck on waiting for IO from dev replace.
It was a false alert, sorry. Strange that the warnings appeared only in the VM running both patches and not otherwise. Though the test did not directly use rename, the possible error scenario I had in mind was some leftover from locking, error handling or state that blocked umount of 011. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
