tree: https://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git blk-iolatency-v7 head: 4f16e9aa09862911cb7ec38061a48b91a72142c3 commit: 4f16e9aa09862911cb7ec38061a48b91a72142c3 [14/14] skip readahead if the cgroup is congested config: sh-allnoconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 4f16e9aa09862911cb7ec38061a48b91a72142c3 # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sh
All errors (new ones prefixed by >>):
mm/readahead.c: In function 'page_cache_sync_readahead':
>> mm/readahead.c:504:6: error: implicit declaration of function
>> 'blk_cgroup_congested'; did you mean 'bdi_rw_congested'?
>> [-Werror=implicit-function-declaration]
if (blk_cgroup_congested())
^~~~~~~~~~~~~~~~~~~~
bdi_rw_congested
cc1: some warnings being treated as errors
vim +504 mm/readahead.c
481
482 /**
483 * page_cache_sync_readahead - generic file readahead
484 * @mapping: address_space which holds the pagecache and I/O vectors
485 * @ra: file_ra_state which holds the readahead state
486 * @filp: passed on to ->readpage() and ->readpages()
487 * @offset: start offset into @mapping, in pagecache page-sized units
488 * @req_size: hint: total size of the read which the caller is
performing in
489 * pagecache pages
490 *
491 * page_cache_sync_readahead() should be called when a cache miss
happened:
492 * it will submit the read. The readahead logic may decide to
piggyback more
493 * pages onto the read request if access patterns suggest it will
improve
494 * performance.
495 */
496 void page_cache_sync_readahead(struct address_space *mapping,
497 struct file_ra_state *ra, struct file
*filp,
498 pgoff_t offset, unsigned long req_size)
499 {
500 /* no read-ahead */
501 if (!ra->ra_pages)
502 return;
503
> 504 if (blk_cgroup_congested())
505 return;
506
507 /* be dumb */
508 if (filp && (filp->f_mode & FMODE_RANDOM)) {
509 force_page_cache_readahead(mapping, filp, offset,
req_size);
510 return;
511 }
512
513 /* do read-ahead */
514 ondemand_readahead(mapping, ra, filp, false, offset, req_size);
515 }
516 EXPORT_SYMBOL_GPL(page_cache_sync_readahead);
517
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
