On 30.08.2018 20:42, Josef Bacik wrote: > We have this open coded in btrfs_destroy_delayed_refs, use the helper > instead. > > Signed-off-by: Josef Bacik <jo...@toxicpanda.com> Reviewed-by: Nikolay Borisov <nbori...@suse.com> > --- > fs/btrfs/disk-io.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > index 11ea2ea7439e..c72ab2ca7627 100644 > --- a/fs/btrfs/disk-io.c > +++ b/fs/btrfs/disk-io.c > @@ -4214,16 +4214,9 @@ static int btrfs_destroy_delayed_refs(struct > btrfs_transaction *trans, > > head = rb_entry(node, struct btrfs_delayed_ref_head, > href_node); > - if (!mutex_trylock(&head->mutex)) { > - refcount_inc(&head->refs); > - spin_unlock(&delayed_refs->lock); > - > - mutex_lock(&head->mutex); > - mutex_unlock(&head->mutex); > - btrfs_put_delayed_ref_head(head); > - spin_lock(&delayed_refs->lock); > + if (btrfs_delayed_ref_lock(delayed_refs, head)) > continue; > - } > + > spin_lock(&head->lock); > while ((n = rb_first(&head->ref_tree)) != NULL) { > ref = rb_entry(n, struct btrfs_delayed_ref_node, >
- Re: [PATCH 22/35] btrfs: make sure we create all new ... Omar Sandoval
- [PATCH 20/35] btrfs: reset max_extent_size on clear in a b... Josef Bacik
- [PATCH 21/35] btrfs: only run delayed refs if we're commit... Josef Bacik
- Re: [PATCH 21/35] btrfs: only run delayed refs if we'... Omar Sandoval
- [PATCH 23/35] btrfs: assert on non-empty delayed iputs Josef Bacik
- Re: [PATCH 23/35] btrfs: assert on non-empty delayed ... Omar Sandoval
- [PATCH 24/35] btrfs: pass delayed_refs_root to btrfs_delay... Josef Bacik
- Re: [PATCH 24/35] btrfs: pass delayed_refs_root to bt... Nikolay Borisov
- [PATCH 25/35] btrfs: make btrfs_destroy_delayed_refs use b... Josef Bacik
- Re: [PATCH 25/35] btrfs: make btrfs_destroy_delayed_r... Nikolay Borisov
- [PATCH 26/35] btrfs: make btrfs_destroy_delayed_refs use b... Josef Bacik
- Re: [PATCH 26/35] btrfs: make btrfs_destroy_delayed_r... Nikolay Borisov
- [PATCH 18/35] btrfs: set max_extent_size properly Josef Bacik
- [PATCH 29/35] btrfs: just delete pending bgs if we are abo... Josef Bacik
- Re: [PATCH 29/35] btrfs: just delete pending bgs if w... Nikolay Borisov
- Re: [PATCH 29/35] btrfs: just delete pending bgs if w... Omar Sandoval
- [PATCH 30/35] btrfs: cleanup pending bgs on transaction ab... Josef Bacik
- Re: [PATCH 30/35] btrfs: cleanup pending bgs on trans... Nikolay Borisov