On 2018/9/5 下午9:00, David Sterba wrote: > On Fri, Aug 31, 2018 at 10:29:27AM +0800, Qu Wenruo wrote: >> This patchset can be fetched from github: >> https://github.com/adam900710/linux/tree/qgroup_inherit_check >> Which is based on v4.19-rc1 tag. >> >> This patchset will first set btrfs_qgroup_inherit structure size limit >> from PAGE_SIZE to fixed SZ_4K. >> I understand this normally will cause compatibility problem, but >> considering how minor this feature is and no sane guy should use it for >> over 100 qgroups, it should be fine in real world. > > Agreed, please update the changelog of 1st patch with description on > what will stop working and under what conditions. The 4k limit sounds > good enough, the real difference would be on architectures with larger > page sizes where the feature would be used.
No problem. > >> The 2nd patch introduce check function for btrfs_qgroup_inherit >> structure and deprecates the following features: >> 1) limit set >> Never utilized by btrfs-progs from the beginning. >> >> 2) copy rfer/excl >> Although btrfs-progs provides support for it as a hidden, >> undocumented feature, it's the easiest way to screw up qgroup >> numbers. >> And we already have patches wondering around the ML to remove such >> support. > > The deprecation should be done in a few steps. First issue a warning > that the feature is deprecated and will be removed in release X. Then > wait until somebody complains (or not) and remove the code in release X. > > The X is something like 4.22, ie. at least 2 cycles after the > deprecation warning is added. Thanks for the deprecation progress. However I'm wondering if the "release X" is really needed in the warning message. (I may forgot to submit the real deprecation patch for that release). Thanks, Qu
signature.asc
Description: OpenPGP digital signature
