Hi Nikolay, Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.19] [also build test ERROR on next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nikolay-Borisov/btrfs-Fix-error-handling-in-btrfs_cleanup_ordered_extents/20181026-194005 config: x86_64-randconfig-x014-201842 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): fs/btrfs/inode.c: In function 'btrfs_cleanup_ordered_extents': >> fs/btrfs/inode.c:10618:0: error: unterminated argument list invoking macro >> "if" }; >> fs/btrfs/inode.c:140:2: error: expected '(' at end of input if (page_start >= offset && page_end <= (offset + bytes - 1) { ^~ >> fs/btrfs/inode.c:140:2: warning: this 'if' clause does not guard... >> [-Wmisleading-indentation] fs/btrfs/inode.c:10618:0: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' }; >> fs/btrfs/inode.c:140:2: error: expected declaration or statement at end of >> input if (page_start >= offset && page_end <= (offset + bytes - 1) { ^~ fs/btrfs/inode.c:122:6: warning: unused variable 'page_end' [-Wunused-variable] u64 page_end = page_start + PAGE_SIZE - 1; ^~~~~~~~ fs/btrfs/inode.c: At top level: fs/btrfs/inode.c:87:12: warning: 'btrfs_setsize' declared 'static' but never defined [-Wunused-function] static int btrfs_setsize(struct inode *inode, struct iattr *attr); ^~~~~~~~~~~~~ fs/btrfs/inode.c:88:12: warning: 'btrfs_truncate' declared 'static' but never defined [-Wunused-function] static int btrfs_truncate(struct inode *inode, bool skip_writeback); ^~~~~~~~~~~~~~ fs/btrfs/inode.c:89:12: warning: 'btrfs_finish_ordered_io' declared 'static' but never defined [-Wunused-function] static int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent); ^~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/inode.c:90:21: warning: 'cow_file_range' declared 'static' but never defined [-Wunused-function] static noinline int cow_file_range(struct inode *inode, ^~~~~~~~~~~~~~ fs/btrfs/inode.c:95:27: warning: 'create_io_em' declared 'static' but never defined [-Wunused-function] static struct extent_map *create_io_em(struct inode *inode, u64 start, u64 len, ^~~~~~~~~~~~ fs/btrfs/inode.c:101:13: warning: '__endio_write_update_ordered' declared 'static' but never defined [-Wunused-function] static void __endio_write_update_ordered(struct inode *inode, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ fs/btrfs/inode.c:71:27: warning: 'btrfs_inode_cachep' defined but not used [-Wunused-variable] static struct kmem_cache *btrfs_inode_cachep; ^~~~~~~~~~~~~~~~~~ vim +/if +10618 fs/btrfs/inode.c 76dda93c Yan, Zheng 2009-09-21 10615 82d339d9 Alexey Dobriyan 2009-10-09 10616 const struct dentry_operations btrfs_dentry_operations = { 76dda93c Yan, Zheng 2009-09-21 10617 .d_delete = btrfs_dentry_delete, 76dda93c Yan, Zheng 2009-09-21 @10618 }; :::::: The code at line 10618 was first introduced by commit :::::: 76dda93c6ae2c1dc3e6cde34569d6aca26b0c918 Btrfs: add snapshot/subvolume destroy ioctl :::::: TO: Yan, Zheng <zheng....@oracle.com> :::::: CC: Chris Mason <chris.ma...@oracle.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
