Re: [PATCH 3/8] btrfs: Remove extent_io_ops::writepage_end_io_hook

[Nikolay Borisov]

On 1.11.18 г. 21:03 ч., Josef Bacik wrote:
> On Thu, Nov 01, 2018 at 02:09:48PM +0200, Nikolay Borisov wrote:
>> This callback is ony ever called for data page writeout so
>> there is no need to actually abstract it via extent_io_ops. Lets just
>> export it, remove the definition of the callback and call it directly
>> in the functions that invoke the callback. Also rename the function to
>> btrfs_writepage_endio_finish_ordered since what it really does is
>> account finished io in the ordered extent data structures.
>> No functional changes.
>>
>> Signed-off-by: Nikolay Borisov <nbori...@suse.com>
> 
> Could send another cleanup patch to remove the struct extent_state *state from
> the arg list as well.

Indeed, once this series lands I will send a follow-up cleanup since I
have some other ideas around writepage_delalloc code cleanups as well.
Thanks

> 
> Reviewed-by: Josef Bacik <jo...@toxicpanda.com>
> 
> Thanks,
> 
> Josef
>