On Mon, Nov 05, 2018 at 12:09:31AM +0800, Eryu Guan wrote: > On Fri, Nov 02, 2018 at 02:29:35PM -0700, Omar Sandoval wrote: > > From: Omar Sandoval <osan...@fb.com> > > > > This series fixes a couple of generic swapfile tests and adds some > > Btrfs-specific swapfile tests. Btrfs swapfile support is scheduled for > > 4.21 [1]. > > > > 1: https://www.spinics.net/lists/linux-btrfs/msg83454.html > > > > Thanks! > > Thanks for the fixes and new tests! > > > > > Omar Sandoval (7): > > generic/{472,496,497}: fix $seeqres typo > > generic/{472,496}: fix swap file creation on Btrfs > > I've merged above two patches, they're two obvious bug fixes. > > > btrfs: test swap file activation restrictions > > btrfs: test invalid operations on a swap file > > btrfs: test swap files on multiple devices > > btrfs: test device add/remove/replace with an active swap file > > btrfs: test balance and resize with an active swap file > > These tests look fine to me, but it'd be really great if btrfs folks > could help review above tests and provide Reviewed-by tags.
All look good to me, Reviewed-by: David Sterba <dste...@suse.com> A few nits I saw: - the command names should not be shortened, ie. 'btrfs subvolume snapshot' instead of 'btrfs subvol snap' - the test description (eg. 3/7 and 4/7) could mention which case is tested, eg. swapfile with compression or COW or snapshot - 4/7 has typo 'nowcow' in a comment
