On 14.11.18 г. 15:35 ч., Johannes Thumshirn wrote:
> This patchset fixes most of the compiler warnings encountered when building
> btrfs with make W=1.
>
> There are two more compiler warnings left in raid56.c:
> CC [M] fs/btrfs/raid56.o
> fs/btrfs/raid56.c: In function ‘finish_rmw’:
> fs/btrfs/raid56.c:1185:6: warning: variable ‘p_stripe’ set but not used
> [-Wunused-but-set-variable]
> int p_stripe = -1;
> ^
> fs/btrfs/raid56.c: In function ‘finish_parity_scrub’:
> fs/btrfs/raid56.c:2343:6: warning: variable ‘p_stripe’ set but not used
> [-Wunused-but-set-variable]
> int p_stripe = -1;
> ^
> but I'm currently unsure how an appropriate fix would look like. As far as I
> can tell these variables have always been unused since they have been
> introduced.
>
> There are still warnings left emitted by kernel-doc but these are subject to
> another patchset, this one only addresses the warnings generated by gcc.
>
> Johannes Thumshirn (6):
> btrfs: remove unused drop_on_err in btrfs_mkdir()
> btrfs: remove set but not used variable err in btrfs_add_link
> btrfs: remove unused function btrfs_sysfs_feature_update()
> btrfs: remove unused variable tree in bio_readpage_error()
> btrfs: remove unused variable tree in end_compressed_bio_write()
> btrfs: unconditionally provide function prototypes from
> free-space-tree.h
>
> fs/btrfs/compression.c | 2 --
> fs/btrfs/extent_io.c | 3 ---
> fs/btrfs/free-space-tree.h | 2 --
> fs/btrfs/inode.c | 16 ++++++----------
> fs/btrfs/sysfs.c | 33 ---------------------------------
> fs/btrfs/sysfs.h | 2 --
> 6 files changed, 6 insertions(+), 52 deletions(-)
For the whole series:
Reviewed-by: Nikolay Borisov <nbori...@suse.com>
However, I have some comments for some of the patches.
>
