Re: [PATCH v2 1/5] btrfs-progs: image: Refactor fixup_devices() to fixup_chunks_and_devices()

[Qu Wenruo]

On 2018/12/4 下午6:18, David Sterba wrote:
> On Tue, Nov 27, 2018 at 04:50:57PM +0800, Qu Wenruo wrote:
>>>> -static int fixup_devices(struct btrfs_fs_info *fs_info,
>>>> -                   struct mdrestore_struct *mdres, off_t dev_size)
>>>> +static int fixup_device_size(struct btrfs_trans_handle *trans,
>>>> +                       struct mdrestore_struct *mdres,
>>>> +                       off_t dev_size)
>>>>  {
>>>> -  struct btrfs_trans_handle *trans;
>>>> +  struct btrfs_fs_info *fs_info = trans->fs_info;
>>>>    struct btrfs_dev_item *dev_item;
>>>>    struct btrfs_path path;
>>>> -  struct extent_buffer *leaf;
>>>>    struct btrfs_root *root = fs_info->chunk_root;
>>>>    struct btrfs_key key;
>>>> +  struct extent_buffer *leaf;
>>>
>>> nit: Unnecessary change
>>
>> Doesn't it look better when all btrfs_ prefix get batched together? :)
> 
> Please don't do unrelated changes like that.

Understood, the github version has that @leaf reverted to the original
location.

Thanks,
Qu