On 05/12/2018 15:46, Julia Lawall wrote:
[...]
>> +@r_patch depends on !context && patch && !org && !report@
>> +expression E;
>> +type T;
>> +@@
>> +
>> +(
>> +- E & ~PAGE_MASK
>> ++ offset_in_page(E)
>> +|
>> +- E & (PAGE_SIZE - 1)
>> ++ offset_in_page(E)
>
> The two lines above should be subsumed by the two lines below. When there
> is a type metavariable that has no other dependencies, an isomorphism will
> consider that it is either present or absent.
Oh OK, I'm sorry I'm not really into cocinelle so I guessed it might
take some iterations.
Do you have an example for this?
> Why not include the cast case for the context and org cases?
This is an oversight actually as I couldn't test it due to a bug in
openSUSE's coccinelle rpm.
Thanks,
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
