> +/* Update inode timestamps and remove security privileges when remapping. */
> +int generic_remap_file_range_touch(struct file *file, bool is_dedupe)
> +{
> +     int ret;
> +
> +     /* If can't alter the file contents, we're done. */
> +     if (is_dedupe)
> +             return 0;
> +
> +     /* Update the timestamps, since we can alter file contents. */
> +     if (!(file->f_mode & FMODE_NOCMTIME)) {
> +             ret = file_update_time(file);
> +             if (ret)
> +                     return ret;
> +     }
> +
> +     /*
> +      * Clear the security bits if the process is not being run by root.
> +      * This keeps people from modifying setuid and setgid binaries.
> +      */
> +     return file_remove_privs(file);
> +}
> +EXPORT_SYMBOL(generic_remap_file_range_touch);

The name seems a little out of touch with what it actually does.
Also why a bool argument instead of the more descriptive flags which
introduced a few patches ago?

Reply via email to