On Fri, Jan 04, 2019 at 03:36:59PM +0200, Nikolay Borisov wrote: > > > On 4.01.19 г. 15:25 ч., Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Cc: Chris Mason <[email protected]> > > Cc: Josef Bacik <[email protected]> > > Cc: David Sterba <[email protected]> > > Cc: [email protected] > > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > --- > > fs/btrfs/sysfs.c | 10 ++-------- > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > Meta-comment, why is there a btrfs debugfs directory at all? All you > > have here is a single "test" file that doesn't do anything except expose > > a variable that never changes. What is this directory and single file > > for? Can I just delete the whole thing? > > > > git blame is your friend - 1bae30982bc8 ("btrfs: add simple debugfs > interface") > > > Apparently David had an idea to do something but it never materialized, > imo the debugfs bits could be removed from sysfs.c
Ok, I'll gladly delete all of the code if the maintainers will accept such a patch. thanks, greg k-h
