On 01/08/2019 01:28 AM, David Sterba wrote:
On Fri, Jan 04, 2019 at 01:31:51PM +0800, Anand Jain wrote:
Adds cli and ioctl to forget a scanned device or forget all stale
devices in the kernel.

I've read my comments to previous postings and I suggested to add more
ways how to specify the device, eg. by uuid or fsid:devid. Have you
considered that?

 Right I responded [1],

  [1]
  https://www.spinics.net/lists/linux-btrfs/msg81059.html

 basically.. I like uuid|fsid:devid idea but,
 - we also need to add the ability to list out uuid|fsid:devid which
 are already scanned, such as [2] (in ml since 2015).

  [2]
  https://patchwork.kernel.org/patch/7362881/

 Further, its better to be consistent with other cli too..
 As of now, 'btrfs device delete' supports only <path|devid> we need
 to add uuid.
 IMO it can be a candidate for separate series?
 I checked volume.c it needs refactor and consolidation of function
 which are involved in finding the device.

 This patch-set helps xfstests to test with btrfs as root fs.[3].

  [3]
  https://patchwork.kernel.org/patch/10733641/

Thanks, Anand

Reply via email to