If we run out of memory during delalloc filling in compress case btrfs is going to BUG_ON. This is unnecessary since the higher levels code (btrfs_run_delalloc_range and its callers) gracefully handle error condtions and error out the page being submittede. Let's be a model kernel citizen and no panic the machine due to ENOMEM and instead fail the IO.
Signed-off-by: Nikolay Borisov <[email protected]> --- fs/btrfs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index cde51ace68b5..b4b2d7f8a98b 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -1197,7 +1197,8 @@ static int cow_file_range_async(struct inode *inode, struct page *locked_page, 1, 0, NULL); while (start < end) { async_cow = kmalloc(sizeof(*async_cow), GFP_NOFS); - BUG_ON(!async_cow); /* -ENOMEM */ + if (!async_cow) + return -ENOMEM; /* * igrab is called higher up in the call chain, take only the * lightweight reference for the callback lifetime -- 2.17.1
