On Tue, Jan 15, 2019 at 07:48:47PM +0800, Qu Wenruo wrote: > Super nice move, it shows the corruption and the cause. > > item 66 key (1714119835648 METADATA_ITEM 0) itemoff 13325 itemsize 33 > item 67 key (10510212874240 METADATA_ITEM 0) itemoff 13283 itemsize 42 > item 68 key (1714119868416 METADATA_ITEM 0) itemoff 13250 itemsize 33
The key order is the most frequent and also very reliable report of the memory bitlips. I think we should add an unconditional check before a leaf or node is written so we catch such errors before the bad data hit the disk. This seems to happen way too often, I believe the check overhead would be acceptable and at least give early warning.
