On Tue, May 21, 2019 at 03:56:09PM +0300, Nikolay Borisov wrote:
[...]
> >     struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
> > +   struct btrfs_inode *btrfs_inode = BTRFS_I(inode);
> >     struct btrfs_ordered_sum *ordered_sum;
> >     struct btrfs_ordered_extent *ordered;
> > -   struct btrfs_ordered_inode_tree *tree = &BTRFS_I(inode)->ordered_tree;
> > +   struct btrfs_ordered_inode_tree *tree = &btrfs_inode->ordered_tree;
> >     unsigned long num_sectors;
> >     unsigned long i;
> >     u32 sectorsize = btrfs_inode_sectorsize(inode);
> > 
> 
> Irrelevant change, this hunk could be dropped. Furthermore, I don't see
> how having an explicit variable brings any value apart from increased
> stack usage.
> 

I have no idea how and why this crept in, probably due to a rebase.

-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumsh...@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Reply via email to