[BUG]
There is a long existing bug that degraded mounted btrfs can allocate new
SINGLE/DUP chunks on a RAID1 fs:
#!/bin/bash
dev1=/dev/test/scratch1
dev2=/dev/test/scratch2
mnt=/mnt/btrfs
umount $mnt &> /dev/null
umount $dev1 &> /dev/null
umount $dev2 &> /dev/null
dmesg -C
mkfs.btrfs -f -m raid1 -d raid1 $dev1 $dev2
wipefs -fa $dev2
mount -o degraded $dev1 $mnt
btrfs balance start --full $mnt
umount $mnt
echo "=== chunk after degraded mount ==="
btrfs ins dump-tree -t chunk $dev1 | grep stripe_len.*type
The result fs will have chunks with SINGLE and DUP only:
=== chunk after degraded mount ===
length 33554432 owner 2 stripe_len 65536 type SYSTEM
length 1073741824 owner 2 stripe_len 65536 type DATA
length 1073741824 owner 2 stripe_len 65536 type DATA|DUP
length 219676672 owner 2 stripe_len 65536 type METADATA|DUP
length 33554432 owner 2 stripe_len 65536 type SYSTEM|DUP
This behavior greatly breaks the RAID1 tolerance.
Even with missing device replaced, if the device with DUP/SINGLE chunks
on them get missing, the whole fs can't be mounted RW any more.
And we already have reports that user even can't mount the fs as some
essential tree blocks got written to those DUP chunks.
[CAUSE]
The cause is pretty simple, we treat missing devices as non-writable.
Thus when we need to allocate chunks, we can only fall back to single
device profiles (SINGLE and DUP).
[FIX]
Just consider the missing devices as WRITABLE, so we allocate new chunks
on them to maintain old profiles.
Signed-off-by: Qu Wenruo <w...@suse.com>
---
fs/btrfs/volumes.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 56f751192a6c..cc30b1fa9306 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -7002,6 +7002,18 @@ static int read_one_dev(struct extent_buffer *leaf,
fill_device_from_item(leaf, dev_item, device);
set_bit(BTRFS_DEV_STATE_IN_FS_METADATA, &device->dev_state);
+
+ /*
+ * We treat missing devices as writable, so that we can maintain
+ * the existing profiles without degrading to DUP/SINGLE.
+ */
+ if (test_bit(BTRFS_DEV_STATE_MISSING, &device->dev_state)) {
+ set_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state);
+ list_add(&device->dev_alloc_list,
+ &fs_devices->alloc_list);
+ fs_devices->rw_devices++;
+ }
+
if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state) &&
!test_bit(BTRFS_DEV_STATE_REPLACE_TGT, &device->dev_state)) {
device->fs_devices->total_rw_bytes += device->total_bytes;
--
2.23.0
