On Wed, Oct 16, 2019 at 12:22:33PM +0300, Nikolay Borisov wrote: > > > On 15.10.19 г. 21:42 ч., Omar Sandoval wrote: > > From: Omar Sandoval <[email protected]> > > > > This isn't actually dio-specific; it just looks up the csums starting at > > the given offset instead of using the page index. Rename it to > > btrfs_lookup_bio_sums_at_offset() and add the dst parameter. We might > > even want to expose __btrfs_lookup_bio_sums() as the public API instead > > of having two trivial wrappers, but I'll leave that for another day. > > IMO exposing btrfs_lookup_bio_sums and adding proper kernel doc for its > parameters is the correct way forward. Consider doing this if the > general direction of this patchset is accepted and before sending the > final revision.
Ok, if I'm not the only one that thinks it's a good idea, I'll go ahead with that.
