Re: [PATCH 2/4] btrfs: inode: remove variable shadowing in btrfs_invalidatepage()

[Nikolay Borisov]

On 17.12.20 г. 7:55 ч., Nikolay Borisov wrote:
> 
> 
> On 17.12.20 г. 6:57 ч., Qu Wenruo wrote:
>> In btrfs_invalidatepage() we re-declare @tree variable as
>> btrfs_ordered_inode_tree.
>>
>> Remove such variable shadowing which can be very confusing.
> 
> You can't do that, because lock_extent_bits expects extent_io_tree !
> 

Ok, nvm, you just factored the var at the beginning of the functions.
OTOH since the ordered tree is used just for lock/unlock why not do
spin_(un)lock(&inode->ordered_tree->lock);