Re: [PATCH v2 14/14] btrfs: Enable W=1 checks for btrfs

[Nikolay Borisov]

On 20.01.21 г. 17:55 ч., Josef Bacik wrote:
> On 1/20/21 5:25 AM, Nikolay Borisov wrote:
>> Now that the btrfs' codebase is clean of W=1 warning let's enable those
>> checks unconditionally for the entire fs/btrfs/ and its subdirectories.
>>
>> Signed-off-by: Nikolay Borisov <nbori...@suse.com>
> 
> Once this is enabled I get
> 
> fs/btrfs/zoned.c: In function ‘btrfs_sb_log_location_bdev’:
> fs/btrfs/zoned.c:491:6: warning: variable ‘zone_size’ set but not used
> [-Wunused-but-set-variable]
>   491 |  u64 zone_size;
>       |      ^~~~~~~~~
> 
> on misc-next.  Thanks,
> 

I know, I intentionally haven't fixed it since:

a)  David might be intending to merge other patches which will utilize
this member

b) It shows a genuine problem that this patchset has uncovered ( I even
mentioned this in the initial cover letter)


> Josef
>