Hi Boris,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.11-rc6]
[also build test ERROR on next-20210125]
[cannot apply to kdave/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Boris-Burkov/btrfs-support-fsverity/20210205-072745
base:    1048ba83fb1c00cd24172e23e8263972f6b5d9ac
config: arc-randconfig-r004-20210204 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/4fb68eb17c9ed350a759646451cba99a19ea7579
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Boris-Burkov/btrfs-support-fsverity/20210205-072745
        git checkout 4fb68eb17c9ed350a759646451cba99a19ea7579
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

   fs/btrfs/super.c: In function 'btrfs_fill_super':
>> fs/btrfs/super.c:1343:6: error: 'struct super_block' has no member named 
>> 's_vop'; did you mean 's_op'?
    1343 |  sb->s_vop = &btrfs_verityops;
         |      ^~~~~
         |      s_op


vim +1343 fs/btrfs/super.c

  1329  
  1330  static int btrfs_fill_super(struct super_block *sb,
  1331                              struct btrfs_fs_devices *fs_devices,
  1332                              void *data)
  1333  {
  1334          struct inode *inode;
  1335          struct btrfs_fs_info *fs_info = btrfs_sb(sb);
  1336          int err;
  1337  
  1338          sb->s_maxbytes = MAX_LFS_FILESIZE;
  1339          sb->s_magic = BTRFS_SUPER_MAGIC;
  1340          sb->s_op = &btrfs_super_ops;
  1341          sb->s_d_op = &btrfs_dentry_operations;
  1342          sb->s_export_op = &btrfs_export_ops;
> 1343          sb->s_vop = &btrfs_verityops;
  1344          sb->s_xattr = btrfs_xattr_handlers;
  1345          sb->s_time_gran = 1;
  1346  #ifdef CONFIG_BTRFS_FS_POSIX_ACL
  1347          sb->s_flags |= SB_POSIXACL;
  1348  #endif
  1349          sb->s_flags |= SB_I_VERSION;
  1350          sb->s_iflags |= SB_I_CGROUPWB;
  1351  
  1352          err = super_setup_bdi(sb);
  1353          if (err) {
  1354                  btrfs_err(fs_info, "super_setup_bdi failed");
  1355                  return err;
  1356          }
  1357  
  1358          err = open_ctree(sb, fs_devices, (char *)data);
  1359          if (err) {
  1360                  btrfs_err(fs_info, "open_ctree failed");
  1361                  return err;
  1362          }
  1363  
  1364          inode = btrfs_iget(sb, BTRFS_FIRST_FREE_OBJECTID, 
fs_info->fs_root);
  1365          if (IS_ERR(inode)) {
  1366                  err = PTR_ERR(inode);
  1367                  goto fail_close;
  1368          }
  1369  
  1370          sb->s_root = d_make_root(inode);
  1371          if (!sb->s_root) {
  1372                  err = -ENOMEM;
  1373                  goto fail_close;
  1374          }
  1375  
  1376          cleancache_init_fs(sb);
  1377          sb->s_flags |= SB_ACTIVE;
  1378          return 0;
  1379  
  1380  fail_close:
  1381          close_ctree(fs_info);
  1382          return err;
  1383  }
  1384  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to