On Wed, 2021-02-17 at 14:38 +0000, Matthew Wilcox wrote:
> On Wed, Feb 17, 2021 at 07:58:41AM -0500, Jeff Layton wrote:
> > -static int ceph_releasepage(struct page *page, gfp_t g)
> > +static int ceph_releasepage(struct page *page, gfp_t gfp_flags)
> > {
> > dout("%p releasepage %p idx %lu (%sdirty)\n", page->mapping->host,
> > page, page->index, PageDirty(page) ? "" : "not ");
> >
> >
> > + if (PageFsCache(page)) {
> > + if (!(gfp_flags & __GFP_DIRECT_RECLAIM) || !(gfp_flags &
> > __GFP_FS))
>
> If you called it 'gfp' instead of 'gfp_flags', you wouldn't go over 80
> columns ;-)
>
> if (!(gfp & __GFP_DIRECT_RECLAIM) || !(gfp & __GFP_FS))
>
Fair enough -- I'll fix it up since you mentioned it. ;)
--
Jeff Layton <[email protected]>
--
Linux-cachefs mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-cachefs