On Wed, Mar 31, 2021 at 07:47:27PM +0100, Matthew Wilcox (Oracle) wrote:
>  void unlock_page_private_2(struct page *page)
>  {
> -     page = compound_head(page);
> -     VM_BUG_ON_PAGE(!PagePrivate2(page), page);
> -     clear_bit_unlock(PG_private_2, &page->flags);
> -     wake_up_page_bit(page, PG_private_2);
> +     struct folio *folio = page_folio(page);
> +     VM_BUG_ON_FOLIO(!FolioPrivate2(folio), folio);

A whitespace between the declaration and the code would be nice.

Otherwise looks good;

Reviewed-by: Christoph Hellwig <[email protected]>

--
Linux-cachefs mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-cachefs

Reply via email to