On Wed, Sep 1, 2010 at 7:41 AM, Jeff Layton <[email protected]> wrote: > > On Tue, 31 Aug 2010 12:55:14 -0700 > Ben Greear <[email protected]> wrote: <snip> > > + else > > + printk(KERN_WARNING "cifs: " > > + "Failed to bind to: %pI4, error: %d\n", > > + &saddr4->sin_addr.s_addr, rc); > > + } > ^^^^^^^^^^^ > For better or worse, the CIFS code uses the cFYI and cERROR macros for > printk's. You should probably do the same here.
This reminds me that as soon as we can figure out a good model/example of file system code using dynamic trace points (and where to store their definitions, presumably somewhere in the documentation area of the kernel source tree) we could consider replacing the cFYIs eventually (it will make debugging mount problems harder when we use dynamic trace points since we sometimes have to have users turn on cifsFYI to find out exactly which request a server is rejecting - and whether it is a server or client issue - but it will make the module smaller). -- Thanks, Steve -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
