On Mon, 1 Nov 2010 16:08:55 +0100 Jiri Slaby <[email protected]> wrote:
> Stanse found that pSMBFile in cifs_ioctl and file->f_path.dentry in > cifs_user_write are dereferenced prior their test to NULL. > > The alternative is not to dereference them before the tests. The patch is > to point out the problem, you have to decide. > > While at it we cache the inode in cifs_user_write to a local variable > and use all over the function. > > Signed-off-by: Jiri Slaby <[email protected]> > Cc: Steve French <[email protected]> > Cc: [email protected] > Cc: Jeff Layton <[email protected]> > Cc: Christoph Hellwig <[email protected]> > --- > fs/cifs/file.c | 25 +++++++++++-------------- > fs/cifs/ioctl.c | 4 ---- > 2 files changed, 11 insertions(+), 18 deletions(-) > Reviewed-by: Jeff Layton <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
