On Wed, 24 Nov 2010 17:49:05 +0530 Suresh Jayaraman <[email protected]> wrote:
> Currently, it is possible to specify 'fsc' mount option even if > CONFIG_CIFS_FSCACHE has not been set. The option is being ignored silently > while the user fscache functionality to work. Fix this by raising error when > the CONFIG option is not set. > > > Reported-by: Jeff Layton <[email protected]> > Signed-off-by: Suresh Jayaraman <[email protected]> > --- > fs/cifs/connect.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 251a17c..32fa4d9 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -1352,6 +1352,11 @@ cifs_parse_mount_options(char *options, const char > *devname, > "supported. Instead set " > "/proc/fs/cifs/LookupCacheEnabled to 0\n"); > } else if (strnicmp(data, "fsc", 3) == 0) { > +#ifndef CONFIG_CIFS_FSCACHE > + cERROR(1, "FS-Cache support needs CONFIG_CIFS_FSCACHE" > + "kernel config option set"); > + return 1; > +#endif > vol->fsc = true; > } else if (strnicmp(data, "mfsymlinks", 10) == 0) { > vol->mfsymlinks = true; > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Jeff Layton <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
