Allowing calls to time out is fine when a user wants that, however we should default to the behavior that allows for the most robust operation for applications.
Defaulting to soft means unreliable behavior for applications in the face of reconnects. Change the default to hard mounts. Signed-off-by: Jeff Layton <[email protected]> --- fs/cifs/connect.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index ece7275..d966976 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -899,7 +899,8 @@ cifs_parse_mount_options(char *options, const char *devname, /* default to only allowing write access to owner of the mount */ vol->dir_mode = vol->file_mode = S_IRUGO | S_IXUGO | S_IWUSR; - /* vol->retry default is 0 (i.e. "soft" limited retry not hard retry) */ + /* default is to retry requests indefinitely */ + vol->retry = 1; /* default is always to request posix paths. */ vol->posix_paths = 1; /* default to using server inode numbers where available */ -- 1.7.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
