This is the third patchset to clean up request timeout behavior in cifs.
There are some siginficant and subtle changes since the last set, so
I've left off any "Reviewed-by" tags on the previous patches. Here's
an overview of what has changed:
- small bugfix in the writepages patch to make it return 0 when there
we're redirtying the pages for the write
- addition of a cleanup patch for dead code in cifs_demultiplex_thread
- DeleteMidQEntry and AllocMidQEntry no longer take the GlobalMid_Lock.
This allows them to be called with that lock held.
- clarification of the locking and state of the mid when the
mid->callback function is called. It's now assumed to be called with
the GlobalMid_Lock held and with it no longer on the pending_mid_q.
Comments were added to clarify this.
- canceled mids are handled by setting the callback function instead
of setting the state and handling them in a special way
- send_nt_cancel creates the cancel request in a different way so that
it doesn't need to be called with the tcon
- NT_CANCEL requests are sent when a process waiting on a synchronous
response catches a fatal signal.
The main impetus of this patchset is to change the way CIFS handles SMB
requests that are taking a long time. I won't rewrite all of that
information, but the description is available here:
http://marc.info/?l=linux-cifs&m=129199588315592&w=2
Another discussion thread surrounding this change is also available
here:
http://marc.info/?l=linux-cifs&m=129142970724511&w=2
I think there is some further work needed in this area, but this is a
good stopping point for 2.6.38 and it seems to fix the most glaring
problems. I'd like to see this merged during the next merge window if
possible.
Comments and suggestions welcome...
Jeff Layton (18):
cifs: don't fail writepages on -EAGAIN errors
cifs: no need to mark smb_ses_list as cifs_demultiplex_thread is
exiting
cifs: make wait_for_free_request take a TCP_Server_Info pointer
cifs: clean up accesses to midCount
cifs: move locked sections out of DeleteMidQEntry and AllocMidQEntry
cifs: move mid result processing into common function
cifs: wait indefinitely for responses
cifs: don't reconnect server when we don't get a response
cifs: clean up sync_mid_result
cifs: allow for different handling of received response
cifs: handle cancelled requests better
cifs: add cifs_call_async
cifs: add ability to send an echo request
cifs: set up recurring workqueue job to do SMB echo requests
cifs: reconnect unresponsive servers
cifs: remove code for setting timeouts on requests
cifs: mangle existing header for SMB_COM_NT_CANCEL
cifs: send an NT_CANCEL request when a process is signalled
fs/cifs/cifs_debug.c | 10 +-
fs/cifs/cifsglob.h | 25 ++-
fs/cifs/cifspdu.h | 15 ++
fs/cifs/cifsproto.h | 7 +
fs/cifs/cifssmb.c | 55 ++++++-
fs/cifs/connect.c | 150 +++++++++--------
fs/cifs/file.c | 93 +++++------
fs/cifs/sess.c | 2 +-
fs/cifs/transport.c | 463 ++++++++++++++++++++++++++------------------------
9 files changed, 459 insertions(+), 361 deletions(-)
--
1.7.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
