On Mon, 28 Feb 2011 14:51:41 -0600 [email protected] wrote: > From: Shirish Pargaonkar <[email protected]> > > > Using kernel crypto APIs for DES encryption during LM and NT hash generation > instead of local functions within cifs. > Source file smbdes.c is deleted sans four functions, one of which > uses ecb des functionality provided by kernel crypto APIs. > > Remove function SMBOWFencrypt. > > Add return codes to various functions such as calc_lanman_hash, > SMBencrypt, and SMBNTencrypt. > > > Signed-off-by: Shirish Pargaonkar <[email protected]> > --- > fs/cifs/Kconfig | 1 + > fs/cifs/Makefile | 2 +- > fs/cifs/cifsencrypt.c | 10 +- > fs/cifs/cifsproto.h | 7 +- > fs/cifs/sess.c | 2 +- > fs/cifs/smbdes.c | 418 > ------------------------------------------------- > fs/cifs/smbencrypt.c | 124 ++++++++++++--- > 7 files changed, 109 insertions(+), 455 deletions(-) > delete mode 100644 fs/cifs/smbdes.c >
Nice work. I'm almost always a fan of less code to maintain ;). That said, I'm not terribly well versed in the intricacies of lanman auth so I'll offer an Acked-by instead of a Reviewed-by: Acked-by: Jeff Layton <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
