On Wed, 27 Apr 2011 17:37:12 +0100 David Howells <[email protected]> wrote:
> Jeff Layton <[email protected]> wrote: > > > + /* don't allow buffer to overflow */ > > + if (byte_count > CIFSMaxBufSize) > > + return -ENOBUFS; > > Shouldn't that be EPROTO too? (ENOBUFS would seem to be wrong anyway). > No, CIFSMaxBufSize is a limitation of this code, and not a protocol limitation. In this case, there's not enough space in this buffer so it seems like the correct error. > > + if (total_in_buf & USHRT_MAX) > > + if (byte_count & USHRT_MAX) > > Use '>' rather than '&'. '&' is wrong without a '~'. > Doh! Good catch -- will fix... -- Jeff Layton <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
