On Mon, Jun 6, 2011 at 2:40 PM, Jeff Layton <[email protected]> wrote: > When signing is enabled, the first session that's established on a > socket will cause a printk like this to pop: > > CIFS VFS: Unexpected SMB signature > > This is because the key exchange hasn't happened yet, so the signature > field is bogus. Don't try to check the signature on the socket until the > first session has been established. Also, eliminate the specific check > for SMB_COM_NEGOTIATE since this check covers that case too. > > Cc: [email protected] > Cc: Shirish Pargaonkar <[email protected]> > Signed-off-by: Jeff Layton <[email protected]> > --- > fs/cifs/cifsencrypt.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c > index dfbd9f1..5a0ee7f 100644 > --- a/fs/cifs/cifsencrypt.c > +++ b/fs/cifs/cifsencrypt.c > @@ -184,7 +184,7 @@ int cifs_verify_signature(struct smb_hdr *cifs_pdu, > if (cifs_pdu == NULL || server == NULL) > return -EINVAL; > > - if (cifs_pdu->Command == SMB_COM_NEGOTIATE) > + if (!server->session_estab) > return 0; > > if (cifs_pdu->Command == SMB_COM_LOCKING_ANDX) { > -- > 1.7.5.2 > >
No more that message in syslog buffer... Reviewed-by: Shirish Pargaonkar <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
