> +static struct mid_q_entry *
> + int *length, bool isLargeBuf, bool *isMultiRsp, char **pbigbuf)
> +{
Same comment for variable naming as for the first patch applies.
> + struct list_head *tmp, *tmp2;
> + struct mid_q_entry *mid_entry = NULL;
> +
> + spin_lock(&GlobalMid_Lock);
> + list_for_each_safe(tmp, tmp2, &server->pending_mid_q) {
> + mid_entry = list_entry(tmp, struct mid_q_entry, qhead);
Please use list_for_each_entry_safe.
> + if (mid_entry->resp_buf) {
> + /* merge response - fix up 1st*/
> + *length = coalesce_t2(buf, mid_entry->resp_buf);
> + if (*length > 0) {
> + *length = 0;
> + mid_entry->multiRsp = true;
> + break;
> + } else {
No need for and else after you break out of the loop anyway.
> + /* all parts received or
> + * packet is malformed
> + */
> + mid_entry->multiEnd = true;
> + goto multi_t2_fnd;
> + }
> + } else {
Similarly here, the goto avoids the needed for the else, allowing the
cut down the indentation a lot.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
