Is there a recreation scenario for this. Your change makes sense but is it possible to hit?
On Fri, Oct 7, 2011 at 2:05 PM, Pavel Shilovsky <[email protected]> wrote: > ..the length field has only 17 bits. > > Signed-off-by: Pavel Shilovsky <[email protected]> > --- > fs/cifs/connect.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 633c246..5779002 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -2807,10 +2807,10 @@ void cifs_setup_cifs_sb(struct smb_vol *pvolume_info, > > /* > * When the server doesn't allow large posix writes, only allow a wsize of > - * 128k minus the size of the WRITE_AND_X header. That allows for a write up > + * 2^17-1 minus the size of the WRITE_AND_X header. That allows for a write > up > * to the maximum size described by RFC1002. > */ > -#define CIFS_MAX_RFC1002_WSIZE (128 * 1024 - sizeof(WRITE_REQ) + 4) > +#define CIFS_MAX_RFC1002_WSIZE (128 * 1024 - 1 - sizeof(WRITE_REQ) + 4) > > /* > * The default wsize is 1M. find_get_pages seems to return a maximum of 256 > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
