Minor clarification - the readme mentions
/proc/module/cifs/parameters/<param>
i.e. echo "value" > /proc/module/cifs/parameters/<param>
but in my system they are under /sys/module/.... not /proc/module/....
On Wed, Oct 12, 2011 at 5:44 PM, Steve French <[email protected]> wrote:
> Shouldn't we note /sys/module/cifs/parameters/echo_retries in the
> message and the readme (since changing at runtime, e.g. to work around
> a server bug temporarily, is probably more common that at module
> install time). I will probably make a minor update to the readme to
> note this if it is not in the patch, but not sure about the printk.
>
> On Wed, Oct 12, 2011 at 1:21 AM, Suresh Jayaraman <[email protected]> wrote:
>> The plan is to deprecate this interface by kernel version 3.4.
>>
>> Changes since v1
>> - add a '\n' to the printk.
>>
>> Reported-by: Alexander Swen <[email protected]>
>> Cc: Jeff Layton <[email protected]>
>> Signed-off-by: Suresh Jayaraman <[email protected]>
>> ---
>> fs/cifs/cifs_debug.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
>> index 2fe3cf1..831fe13 100644
>> --- a/fs/cifs/cifs_debug.c
>> +++ b/fs/cifs/cifs_debug.c
>> @@ -526,6 +526,9 @@ static ssize_t cifs_oplock_proc_write(struct file *file,
>> char c;
>> int rc;
>>
>> + printk(KERN_WARNING "CIFS: The /proc/fs/cifs/OplockEnabled interface
>> "
>> + "will be removed in kernel version 3.4. Please migrate to "
>> + "using the 'enable_oplocks' module parameter in cifs.ko.\n");
>> rc = get_user(c, buffer);
>> if (rc)
>> return rc;
>>
>
>
>
> --
> Thanks,
>
> Steve
>
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
