Looks fine. Reviewed-by: Steve French <[email protected]>
Do we care about lines over 80 in length? (I don't care unless it improves readability to fix). On Wed, Nov 23, 2011 at 6:33 AM, Jeff Layton <[email protected]> wrote: > ...don't use "ipaddr" here since it's a const pointer. > > Signed-off-by: Jeff Layton <[email protected]> > --- > resolve_host.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/resolve_host.c b/resolve_host.c > index 69859a3..17cbd10 100644 > --- a/resolve_host.c > +++ b/resolve_host.c > @@ -70,8 +70,7 @@ int resolve_host(const char *host, char *addrstr) > > if (sin6->sin6_scope_id) { > len = strnlen(tmpbuf, sizeof(tmpbuf)); > - ipaddr = tmpbuf + len; > - snprintf(ipaddr, sizeof(tmpbuf) - len, "%%%u", > + snprintf(tmpbuf + len, sizeof(tmpbuf) - len, > "%%%u", > sin6->sin6_scope_id); > } > break; > -- > 1.7.6.4 > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
