On Wed, 17 Oct 2012 12:29:49 -0400
[email protected] wrote:

> From: Scott Lovenberg <[email protected]>
> 
> Signed-off-by: Scott Lovenberg <[email protected]>
> ---
>  mount.cifs.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/mount.cifs.c b/mount.cifs.c
> index 756fce2..061ce32 100644
> --- a/mount.cifs.c
> +++ b/mount.cifs.c
> @@ -1335,6 +1335,7 @@ static int parse_unc(const char *unc_name, struct 
> parsed_mount_info *parsed_info
>       }
>  
>       /* Set up "host" and "share" pointers based on UNC format. */
> +     /* TODO: Remove support for NFS syntax as of cifs-utils-6.0. */
>       if (strncmp(unc_name, "//", 2) && strncmp(unc_name, "\\\\", 2)) {
>               /*
>                * check for nfs syntax (server:/share/prepath)
> @@ -1351,6 +1352,9 @@ static int parse_unc(const char *unc_name, struct 
> parsed_mount_info *parsed_info
>               share++;
>               if (*share == '/')
>                       ++share;
> +             fprintf(stderr, "WARNING: using NFS syntax for mounting CIFS "
> +                     "shares is deprecated and will be removed in cifs-utils"
> +                     "-6.0. Please migrate to UNC syntax.");
>       } else {
>               host = unc_name + 2;
>               hostlen = strcspn(host, "/\\");

Steve suggested resending this patch and cc'ing samba and
samba-technical. Also, add a bit more explanation about why we're
making this change so people are clear about why it's coming.

You should also prefix the subject with something like "mount.cifs: "
to make it clear what this patch is intended for.

I think that's reasonable -- could you do that?

Thanks,
-- 
Jeff Layton <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to