On Mon, Oct 22, 2012 at 12:57 AM, Scott Lovenberg <[email protected]> wrote: > On Mon, Oct 22, 2012 at 1:01 AM, <[email protected]> wrote: >> >> From: Shirish Pargaonkar <[email protected]> > [...] >> + int remap; >> + char *altstr = NULL; >> + struct nls_table *cp; >> + struct tcon_link *tlink = NULL; >> + struct cifs_tcon *tcon = NULL; >> + >> + cp = cifs_sb->local_nls; >> + remap = cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR; >> + >> + tlink = cifs_sb_tlink(cifs_sb); >> + if (tlink) { >> + tcon = tlink_tcon(tlink); >> + if (tcon && !(tcon->unix_ext)) >> + altstr = strchr(source, ':'); >> + cifs_put_tlink(tlink); >> + } >> >> - if (!mapChars) >> + if (!remap || altstr) >> return cifs_strtoUTF16(target, source, PATH_MAX, cp); > > Would it make more sense for "remap" to be of type unsigned int or size_t? > > > -- > Peace and Blessings, > -Scott.
I think variable remap of type bool should be sufficient too. Regards, Shirish -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
