On Sun, Sep 13, 2015 at 12:20:36PM +0100, Heiko Stübner wrote: > Again a result of the gpio-clock-liberation the rk3368 needs the > pclk_pd_pmu marked as critical, to boot successfully. > > Reported-by: Mark Rutland <[email protected]> > Signed-off-by: Heiko Stuebner <[email protected]>
FWIW: Tested-by: Mark Rutland <[email protected]> I'm surprised that we don't describe these as critical in the DT, given that this isn't really an internal property of the clock controller, but rather what happens to be attached to it. That ship appears to have sailed, however. Thanks, Mark. > --- > should go on top of clk-fixes. Sorry only finding these piece > by piece :-) . > > drivers/clk/rockchip/clk-rk3368.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/clk/rockchip/clk-rk3368.c > b/drivers/clk/rockchip/clk-rk3368.c > index 9c5d61e..7e6b783 100644 > --- a/drivers/clk/rockchip/clk-rk3368.c > +++ b/drivers/clk/rockchip/clk-rk3368.c > @@ -818,6 +818,10 @@ static struct rockchip_clk_branch rk3368_clk_branches[] > __initdata = { > GATE(0, "sclk_timer00", "xin24m", CLK_IGNORE_UNUSED, > RK3368_CLKGATE_CON(24), 0, GFLAGS), > }; > > +static const char *const rk3368_critical_clocks[] __initconst = { > + "pclk_pd_pmu", > +}; > + > static void __init rk3368_clk_init(struct device_node *np) > { > void __iomem *reg_base; > @@ -862,6 +866,8 @@ static void __init rk3368_clk_init(struct device_node *np) > RK3368_GRF_SOC_STATUS0); > rockchip_clk_register_branches(rk3368_clk_branches, > ARRAY_SIZE(rk3368_clk_branches)); > + rockchip_clk_protect_critical(rk3368_critical_clocks, > + ARRAY_SIZE(rk3368_critical_clocks)); > > rockchip_clk_register_armclk(ARMCLKB, "armclkb", > mux_armclkb_p, ARRAY_SIZE(mux_armclkb_p), > -- > 2.5.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
