On Mon, Sep 28, 2015 at 5:03 AM, Bhupesh SHARMA <bhupesh.li...@gmail.com> wrote: > Hi Rob, > > On Sat, Sep 5, 2015 at 2:45 AM, Rob Herring <robherri...@gmail.com> wrote: >> On Fri, Sep 4, 2015 at 2:05 AM, Bhupesh Sharma >> <bhupesh.sha...@freescale.com> wrote: >>> This patch updates the LS2085a DTSI (DTS Include) file to add >>> support for various peripherals supported by FSL LS2085a SoC, for e.g.: >>> - USB 3.0 Host >>> - PMU >>> - CCN-504 >>> - Watchdog >>> - SATA >>> - SPI >>> - PCIe >>> - etc. >>> >>> Signed-off-by: Bhupesh Sharma <bhupesh.sha...@freescale.com> >>> Signed-off-by: Jaiprakash Singh <b44...@freescale.com> >>> Signed-off-by: Alison Wang <alison.w...@freescale.com> >>> Signed-off-by: Liu Gang <gang....@freescale.com> >>> Signed-off-by: Minghuan Lian <minghuan.l...@freescale.com> >>> Signed-off-by: Shaohui Xie <shaohui....@freescale.com> >>> Signed-off-by: Nikhil Badola <nikhil.bad...@freescale.com> >>> Signed-off-by: Yangbo Lu <yangbo...@freescale.com> >>> Signed-off-by: Scott Wood <scottw...@freescale.com> >>> --- >>> arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 469 >>> +++++++++++++++++++++++- >>> 1 file changed, 459 insertions(+), 10 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi >>> b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi >>> index 333d942..5fee0a7 100644 >>> --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi > > [snip..]
>>> @@ -139,25 +173,440 @@ >>> <1 10 0x8>; /* Hypervisor PPI, active-low */ >>> }; >>> >>> + amba { >>> + compatible = "arm,amba-bus"; >> >> Use simple-bus. "arm,amba-bus" is meaningless. > > Not sure I understand your comment here. Without this > compatible in place I cannot see the 'drivers/amba/bus.c' > amba_match() function getting called which in turn will call the > amba_lookup() function, > thus invoking the probe function of the sp805_wdt driver. I'm not saying the devices are not amba_bustype devices. That has nothing to do with matching them. "arm,primecell" is what matters there. There is nothing visible to s/w about "arm,amba-bus," and it is ambiguous as there are multiple types of AMBA buses (APB, AHB, AXI). So unless you have bus level registers, use simple-bus. If you have doubts, try changing it and see that it still works. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html