On 09/24, Guenter Roeck wrote:
> On 09/24/2015 05:46 PM, York Sun wrote:
> >+ /* may have some garbage in high bits,
> >+ * will be cut of by mask
> >+ */
>
> Does the clock subsystem use network subsystem style multiline comments ?
No. We follow the traditional multi-line commenting style as in
Documentation/CodingStyle.
> >+ return ret;
> >+ }
> >+
> >+ /* Check if si5338 exists */
> >+ if ((n & REG5338_DEV_CONFIG2_MASK) != REG5338_DEV_CONFIG2_VAL) {
> >+ dev_err(&client->dev,
> >+ "Chip returned unexpected value from reg %d: %d,
> >expected %d. It is not %s\n",
>
> 0x%x for register values ?
Or %#x
>
> >+ REG5338_DEV_CONFIG2, n, REG5338_DEV_CONFIG2_VAL,
> >+ id->name);
> >+ return -EIO;
> >+ }
> >+
> >+ dev_info(&client->dev, "Chip %s is found\n", id->name);
>
> I personally dislike that noise.
>
Me too.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
