On 10/05, Mike Looijmans wrote: > On 02-10-15 21:18, Stephen Boyd wrote: > >On 10/02, Mike Looijmans wrote: > >>This patch adds the driver and devicetree documentation for the > >>Silicon Labs SI514 clock generator chip. This is an I2C controlled > >>oscillator capable of generating clock signals ranging from 100kHz > >>to 250MHz. > >> > >>Signed-off-by: Mike Looijmans <[email protected]> > >>--- > > > >Applied to clk-next. We can handle any stuff about assigned rates > >in a follow up patch. > > > >Also, I squashed in this for some cleanup. > > > >diff --git a/drivers/clk/clk-si514.c b/drivers/clk/clk-si514.c > >index 779aebcd884b..6af7dce54241 100644 > >--- a/drivers/clk/clk-si514.c > >+++ b/drivers/clk/clk-si514.c > >@@ -16,7 +16,6 @@ > > * GNU General Public License for more details. > > */ > > > >-#include <linux/clk.h> > > Interesting - I only added this include because of your comment: > "I'd expect some sort of linux/clk.h include here if we're using > clk APIs." > > Could you elaborate on that, I'm confused now... >
The driver is only using the clk provider APIs that are in clk-provider.h, because you removed the part that was calling clk_set_rate() (which is a clk consumer API). So before that change we would have needed the clk.h include, but now it compiles fine without it. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
