On Fri, Sep 22, 2023 at 10:54:33AM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct adf_fw_counters. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Giovanni Cabiddu <[email protected]> > Cc: Herbert Xu <[email protected]> > Cc: "David S. Miller" <[email protected]> > Cc: Nathan Chancellor <[email protected]> > Cc: Nick Desaulniers <[email protected]> > Cc: Tom Rix <[email protected]> > Cc: Adam Guerin <[email protected]> > Cc: Lucas Segarra Fernandez <[email protected]> > Cc: Andy Shevchenko <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Kees Cook <[email protected]>
Reviewed-by: Gustavo A. R. Silva <[email protected]> Thanks -- Gustavo > --- > drivers/crypto/intel/qat/qat_common/adf_fw_counters.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/intel/qat/qat_common/adf_fw_counters.c > b/drivers/crypto/intel/qat/qat_common/adf_fw_counters.c > index cb6e09ef5c9f..6abe4736eab8 100644 > --- a/drivers/crypto/intel/qat/qat_common/adf_fw_counters.c > +++ b/drivers/crypto/intel/qat/qat_common/adf_fw_counters.c > @@ -34,7 +34,7 @@ struct adf_ae_counters { > > struct adf_fw_counters { > u16 ae_count; > - struct adf_ae_counters ae_counters[]; > + struct adf_ae_counters ae_counters[] __counted_by(ae_count); > }; > > static void adf_fw_counters_parse_ae_values(struct adf_ae_counters > *ae_counters, u32 ae, > -- > 2.34.1 > >
