On Tue, Dec 10, 2013 at 08:26:19PM +0100, Marek Vasut wrote: > When finishing the ahash request, the ahash_op_unaligned_done() will > call complete() on the request. Yet, this will not call the correct > complete callback. The correct complete callback was previously stored > in the requests' private data, as seen in ahash_op_unaligned(). This > patch restores the correct complete callback and .data field of the > request before calling complete() on it. > > Signed-off-by: Marek Vasut <[email protected]> > Cc: Herbert Xu <[email protected]> > Cc: David S. Miller <[email protected]> > Cc: Fabio Estevam <[email protected]> > Cc: Shawn Guo <[email protected]> > Cc: [email protected] > --- > crypto/ahash.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/crypto/ahash.c b/crypto/ahash.c > index 793a27f..a92dc38 100644 > --- a/crypto/ahash.c > +++ b/crypto/ahash.c > @@ -213,7 +213,10 @@ static void ahash_op_unaligned_done(struct > crypto_async_request *req, int err) > > ahash_op_unaligned_finish(areq, err); > > - complete(data, err); > + areq->base.complete = complete; > + areq->base.data = data; > + > + complete(&areq->base, err);
This looks completely bogus. While restoring areq isn't wrong per se, calling complete with &areq->base makes no sense. The original completion data is in the variable "data". Which driver relies on this behaviour? Also, does your subsequent patches rely on this? Cheers, -- Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
