On Wednesday, March 19, 2014 at 01:46:42 AM, chandramouli narayanan wrote: > Sorry, there seems to be a problem with the patch. Let me retest from > the list again and repost.
Before you do that, please ... 1) Please do not top-post in replies 2) Fix the changelog (see below) > On Tue, 2014-03-18 at 17:12 -0700, chandramouli narayanan wrote: > > This git patch adds x86_64 AVX2 optimization of SHA1 transform > > to crypto support. The patch has been tested with 3.14.0-rc1 > > kernel. > > > > On a Haswell desktop, with turbo disabled and all cpus running > > at maximum frequency, tcrypt shows AVX2 performance improvement > > from 3% for 256 bytes update to 16% for 1024 bytes update over > > AVX implementation. > > > > This patch adds sha1_avx2_transform(), the glue, build and > > configuration changes needed for AVX2 optimization of SHA1 transform to > > crypto support. > > > > Changes noted from the initial version of this patch are based on the > > feedback from the community: > > a) check for BMI2 in addition to AVX2 support since > > __sha1_transform_avx2() uses rorx > > b) Since the module build has dependency on 64bit, it is > > redundant to check it in the code here. > > c) coding style cleanup > > d) simplification of the assembly code where macros are repetitively > > used. All this changelog for the patch goes under the diffstat ... oh, but where did the diffstat go anyway ? I think you are producing the patch in some weird way. I suggest you produce the patch like so: $ git format-patch HEAD~1 -o /tmp/mypatches-to-submit/ Then to submit the email with a patch, do: $ git send-email --annotate [email protected] \ --cc="[email protected]" --cc="[email protected]" \ /tmp/mypatches-to-submit/*.patch Also, you can avoid adding these --cc="..." options each and every time by simply adding "Cc: Per Son <[email protected]>" tag to your patch's description just below the 'Signed-off-by:' tag. Moreover, when sending a V3 of a patch, adjust the subject as such: [PATCH V3] SHA1 transform: x86_64 AVX2 optimization or if it's a patch which is part of series: [PATCH 1/n V3] SHA1 transform: x86_64 AVX2 optimization Hope that helps :) [...] -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
